[all-commits] [llvm/llvm-project] 03fd5f: [mlir][tosa] Enable Constant Operand Check by Defa...

[Luke Hutton via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 03fd5f125b61ad6e80eb589b52db0bee22bdd540
      https://github.com/llvm/llvm-project/commit/03fd5f125b61ad6e80eb589b52db0bee22bdd540
  Author: Luke Hutton <luke.hutton at arm.com>
  Date:   2025-08-01 (Fri, 01 Aug 2025)

  Changed paths:
    M mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
    M mlir/test/Dialect/Tosa/dynamic_extension.mlir
    M mlir/test/Dialect/Tosa/level_check.mlir

  Log Message:
  -----------
  [mlir][tosa] Enable Constant Operand Check by Default in TOSA Validation Pass (#150598)

Previous behaviour was to only run the check for constant operands when
the "strict-op-spec-alignment" check was enabled. However, this type of
check seems more generally useful without this option enabled. For
example, tosa-to-linalg doesn't enable the "strict-op-spec-alignment"
option when running the tosa-validate pass, but it does expect operands
to be constant.

By enabling this type of checking by default, lowering that don't
support non constant operands and don't use the
"strict-op-spec-alignment" option will fail early, rather than later in
the lowering pipeline.

Should a use-case need to disable this type of checking,
`--tosa-validate="extension=dynamic"` can be used.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications