[all-commits] [llvm/llvm-project] a7b58e: [lldb] Remove %T from lit tests (#151343)

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a7b58e74a080152c30fc5eb5f749e2254c277938
      https://github.com/llvm/llvm-project/commit/a7b58e74a080152c30fc5eb5f749e2254c277938
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-07-30 (Wed, 30 Jul 2025)

  Changed paths:
    M lldb/test/Shell/Commands/command-disassemble-process.yaml
    M lldb/test/Shell/Commands/command-image-lookup.yaml
    M lldb/test/Shell/Minidump/Windows/arm-fp-unwind.test
    M lldb/test/Shell/Minidump/Windows/broken-unwind.test
    M lldb/test/Shell/Minidump/Windows/find-module.test
    M lldb/test/Shell/Minidump/memory-region-from-module.yaml
    M lldb/test/Shell/ObjectFile/Breakpad/uuid-matching-mac.test
    M lldb/test/Shell/ObjectFile/ELF/minidebuginfo-set-and-hit-breakpoint.test
    M lldb/test/Shell/SymbolFile/Breakpad/inline-record.test
    M lldb/test/Shell/SymbolFile/Breakpad/line-table-discontinuous-file-ids.test
    M lldb/test/Shell/SymbolFile/Breakpad/line-table-edgecases.test
    M lldb/test/Shell/SymbolFile/Breakpad/line-table-missing-file.test
    M lldb/test/Shell/SymbolFile/Breakpad/line-table-mixed-path-styles.test
    M lldb/test/Shell/SymbolFile/Breakpad/line-table.test
    M lldb/test/Shell/SymbolFile/Breakpad/symtab-macho.test
    M lldb/test/Shell/SymbolFile/Breakpad/symtab-sorted-by-size.test
    M lldb/test/Shell/SymbolFile/Breakpad/symtab.test
    M lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml
    M lldb/test/Shell/SymbolFile/DWARF/dwo-missing-error.test
    M lldb/test/Shell/SymbolFile/DWARF/dwo-relative-path.s
    M lldb/test/Shell/SymbolFile/DWARF/x86/debug_loclists-dwo.s
    M lldb/test/Shell/SymbolFile/DWARF/x86/debug_rnglists-dwo.s
    M lldb/test/Shell/SymbolFile/DWARF/x86/dwo-type-in-main-file.s
    M lldb/test/Shell/SymbolFile/PDB/class-layout.test
    M lldb/test/Shell/SymbolFile/PDB/compilands.test
    M lldb/test/Shell/SymbolFile/PDB/enums-layout.test
    M lldb/test/Shell/SymbolFile/PDB/func-symbols.test
    M lldb/test/Shell/SymbolFile/PDB/pointers.test
    M lldb/test/Shell/SymbolFile/PDB/type-quals.test
    M lldb/test/Shell/SymbolFile/PDB/typedefs.test
    M lldb/test/Shell/SymbolFile/PDB/variables.test

  Log Message:
  -----------
  [lldb] Remove %T from lit tests (#151343)

%T has been deprecated for about seven years, mostly because it is not
unique to each test which can lead to races. This patch updates the few
remaining tests in lldb that use %T to not use it (either directly using
files or creating their own temp dir). The eventual goal is to remove
support for %T from llvm-lit given few tests use it and it still has
racey behavior.

This patch errors on the side of creating new temp dirs even when not
strictly necessary to avoid needing to update filenames inside filecheck
matchers.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications