[all-commits] [llvm/llvm-project] 787d28: [AMDGPU][gfx12] Clean-up implementation of waits b...

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Mon Jul 28 06:28:17 PDT 2025


  Branch: refs/heads/users/pierre-vh/cleanup-wait-before-scope-sys-store
  Home:   https://github.com/llvm/llvm-project
  Commit: 787d284fa2759411c054269e883230a8a6a2f921
      https://github.com/llvm/llvm-project/commit/787d284fa2759411c054269e883230a8a6a2f921
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-07-28 (Mon, 28 Jul 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-local-volatile.ll

  Log Message:
  -----------
  [AMDGPU][gfx12] Clean-up implementation of waits before SCOPE_SYS stores

We can do it all in finalizeStore if we ensure it always sees the stores.
For that, I needed to fix a hidden bug where finalizeStore wouldn't see all stores
because sometimes the iterator got out-of-sync and didn't point to the store anymore.

This also removes the waits before volatile LDS stores which never needed it, that was a bug until now.


  Commit: d591d5db0e27db146bd5ca6b5bb463d429ea9385
      https://github.com/llvm/llvm-project/commit/d591d5db0e27db146bd5ca6b5bb463d429ea9385
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-07-28 (Mon, 28 Jul 2025)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/mad-mix-hi-bf16.ll

  Log Message:
  -----------
  fix test


Compare: https://github.com/llvm/llvm-project/compare/db04f102f532...d591d5db0e27

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list