[all-commits] [llvm/llvm-project] 73e20c: review comments:

[Sameer Sahasrabuddhe via All-commits]

  Branch: refs/heads/users/ssahasra/waitcnt-lds-direct-2
  Home:   https://github.com/llvm/llvm-project
  Commit: 73e20c7d04f51fdcdb67ffd79326679366b26117
      https://github.com/llvm/llvm-project/commit/73e20c7d04f51fdcdb67ffd79326679366b26117
  Author: Sameer Sahasrabuddhe <sameer.sahasrabuddhe at amd.com>
  Date:   2025-07-28 (Mon, 28 Jul 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
    M llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp
    M llvm/lib/Target/AMDGPU/SOPInstructions.td
    M llvm/test/CodeGen/AMDGPU/GlobalISel/memory-legalizer-atomic-fence.ll
    M llvm/test/CodeGen/AMDGPU/insert-waitcnts-fence-soft.mir

  Log Message:
  -----------
  review comments:

- try renaming to S_WAITCNT_lds_direct
- be consistent (even at the cost of brevity?)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications