[all-commits] [llvm/llvm-project] aa494b: [MLIR][OpenMP] Remove Generic-SPMD early detection

Sergio Afonso via All-commits all-commits at lists.llvm.org
Mon Jul 28 03:46:39 PDT 2025


  Branch: refs/heads/users/skatrak/flang-generic-01-mlir-pattern
  Home:   https://github.com/llvm/llvm-project
  Commit: aa494bd99eba689a289973226aec065c0b0f0a7a
      https://github.com/llvm/llvm-project/commit/aa494bd99eba689a289973226aec065c0b0f0a7a
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2025-07-28 (Mon, 28 Jul 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenMP/OpenMPEnums.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/openmp-target-generic-spmd.mlir

  Log Message:
  -----------
  [MLIR][OpenMP] Remove Generic-SPMD early detection

This patch removes logic from MLIR to attempt identifying Generic kernels that
could be executed in SPMD mode.

This optimization is done by the OpenMPOpt pass for Clang and is only required
here to circumvent missing support for the new DeviceRTL APIs used in MLIR to
LLVM IR translation that Clang doesn't currently use (e.g.
`kmpc_distribute_static_loop` ). Removing checks in MLIR avoids duplicating the
logic that should be centralized in the OpenMPOpt pass.

Additionally, offloading kernels currently compiled through the OpenMP dialect
fail to run parallel regions properly when in Generic mode. By disabling early
detection, this issue becomes apparent for a range of kernels where this was
masked by having them run in SPMD mode.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list