[all-commits] [llvm/llvm-project] 0c8042: [mlir][Transforms][NFC] Dialect Conversion: Improv...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c804270d1264520808d02263f61ab4a02745d60
      https://github.com/llvm/llvm-project/commit/0c804270d1264520808d02263f61ab4a02745d60
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-07-26 (Sat, 26 Jul 2025)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] Dialect Conversion: Improve `insert` callbacks (#150753)

This commit makes some minor NFC-style improvements to the
`notifyBlockInserted` and `notifyOperationInserted` implementations:

* Rename some variables.
* Add more comments and document the fact the current mechanism has a
bug when running in "rollback allowed" mode.
* Move some code from the `notify...` functions into the constructor of
the respective `IRRewrite` objects. This is in preparation of the
One-Shot Dialect Conversion refactoring. The moved pieces of code are
not needed in "no rollback" mode and properly encapsulated inside of
`IRRewrite`, which is also not needed in "no rollback" mode.
* Slightly improve `-debug` output.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications