[all-commits] [llvm/llvm-project] 5ebdfe: [clang][Modules] Respect -fno-cxx-modules as a dri...

Cyndy Ishida via All-commits all-commits at lists.llvm.org
Fri Jul 25 13:17:30 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ebdfe386e3bb9f959719f76a9ad689f843c2164
      https://github.com/llvm/llvm-project/commit/5ebdfe386e3bb9f959719f76a9ad689f843c2164
  Author: Cyndy Ishida <cyndy_ishida at apple.com>
  Date:   2025-07-25 (Fri, 25 Jul 2025)

  Changed paths:
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/test/Driver/modules.mm

  Log Message:
  -----------
  [clang][Modules] Respect -fno-cxx-modules as a driver flag (#150349)

The mentioned flag is already both a cc1 & driver flag; however, whether
it is respected was tied to either:
1. Whether it was passed as a cc1 option (`Xclang`)
2. or `-fmodules` accompanying it

This poses a consistency problem where `std=c++20` enables the modules
feature, independent of other module settings.
This patch resolves this issue by checking for the presence
unconditionally & passing it down to cc1 when applicable.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list