[all-commits] [llvm/llvm-project] a073cb: [X86] Fix misassemble due to not storing registers...

[circuit10 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a073cbbb1aeaaeac01b12e818fe47e4c04080aac
      https://github.com/llvm/llvm-project/commit/a073cbbb1aeaaeac01b12e818fe47e4c04080aac
  Author: circuit10 <heath.mitchell27 at gmail.com>
  Date:   2025-07-24 (Thu, 24 Jul 2025)

  Changed paths:
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
    A llvm/test/MC/X86/intel-syntax-parentheses.s

  Log Message:
  -----------
  [X86] Fix misassemble due to not storing registers to state machine on RParen (#150252)

This fixes #116883.

The x86 parser saves any register it encounters to a TmpReg field in its
state machine, then on encountering the next valid token immediately
afterwards saves it to either BaseReg, or IndexReg if BaseReg was
already filled. However, this saving logic was missing on the RParen
token handler, causing the parser to "forget" the register immediately
beforehand. This also would prevent later validation logic from
detecting the addressing mode as invalid, leading to a silent
misassembly rather than an error.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications