[all-commits] [llvm/llvm-project] 7d9f91: Update comment on getCustomDiagID; NFC

Aaron Ballman via All-commits all-commits at lists.llvm.org
Tue Jul 22 04:27:26 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7d9f913bb4164b8aaecfc17accebd44044592115
      https://github.com/llvm/llvm-project/commit/7d9f913bb4164b8aaecfc17accebd44044592115
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M clang/include/clang/Basic/Diagnostic.h
    M clang/include/clang/Basic/DiagnosticIDs.h

  Log Message:
  -----------
  Update comment on getCustomDiagID; NFC

These APIs should almost never be used in Clang, so documenting that
more clearly. The problem is that the diagnostics are never associated
with a diagnostic group, so users have no way to control warning
behavior associated with the diagnostic. That makes for a poor user
experience. Instead, use a real diagnostic whenever possible or the API
taking a CustomDiagDesc as a last resort.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list