[all-commits] [llvm/llvm-project] 93af94: [PSI] Ensure hot and could counter thresholds are ...

[xur-llvm via All-commits]

  Branch: refs/heads/users/xur-llvm/icp_work
  Home:   https://github.com/llvm/llvm-project
  Commit: 93af9449e3bebff17323a480323ee025c766fafe
      https://github.com/llvm/llvm-project/commit/93af9449e3bebff17323a480323ee025c766fafe
  Author: Rong Xu <xur at google.com>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M llvm/lib/Analysis/ProfileSummaryInfo.cpp

  Log Message:
  -----------
  [PSI] Ensure hot and could counter thresholds are distinct

If hot and cold thresholds are identical, both isColdCount() and
isHotCount() can return true due to inclusive checks in these
functions. This is undesirable.

This patch ensures distinct hot and cold counter thresholds.
An alternative fix is to make the check in isColdCount() exclusive.
But that requires many test case changes.


  Commit: ae13963fbc0fe3e3c6f76b33f08ca6db9bbda9a1
      https://github.com/llvm/llvm-project/commit/ae13963fbc0fe3e3c6f76b33f08ca6db9bbda9a1
  Author: Rong Xu <xur at google.com>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
    M llvm/test/ThinLTO/X86/memprof-icp.ll

  Log Message:
  -----------
  [ICP] Add a few tunings to indirect-call-promtion

Indirect-call promotion (ICP) has been adjusted with the following
tunings, both of which are enabled by default:
  (1) Candidate functions can be now ICP'd even if only a declaration
      is present.
  (2) All non-cold candidate functions are now considered by ICP.
      Previously, only hot targets were considered.
These changes are expected to improve performance, with some large
Google benchmarks showing up to a 0.3% improvement.


Compare: https://github.com/llvm/llvm-project/compare/95d89e0d2a07...ae13963fbc0f

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications