[all-commits] [llvm/llvm-project] 8e749c: [PSI] Ensure hot and could counter thresholds are ...

[xur-llvm via All-commits]

  Branch: refs/heads/users/xur-llvm/icp_work
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e749c034d166bb67c84c4fb26490fbb29a63a48
      https://github.com/llvm/llvm-project/commit/8e749c034d166bb67c84c4fb26490fbb29a63a48
  Author: Rong Xu <xur at google.com>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M llvm/lib/Analysis/ProfileSummaryInfo.cpp

  Log Message:
  -----------
  [PSI] Ensure hot and could counter thresholds are distinct

If hot and cold thresholds are identical, both isColdCount() and
isHotCount() can return true due to inclusive checks in these
functions. This is undesirable.

This patch ensures distinct hot and cold counter thresholds.
An alternative fix is to make the check in isColdCount() exclusive.
But that requires many test case changes.


  Commit: 95d89e0d2a0767ea9774a4a4ed9ba9259a90ca98
      https://github.com/llvm/llvm-project/commit/95d89e0d2a0767ea9774a4a4ed9ba9259a90ca98
  Author: Rong Xu <xur at google.com>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
    M llvm/test/ThinLTO/X86/memprof-icp.ll

  Log Message:
  -----------
  [ICP] Add a few tunings to indirect-call-promtion

Indirect-call promotion (ICP) has been adjusted with the following
tunings, both of which are enabled by default:
  (1) Candidate functions can be now ICP'd even if only a declaration
      is present.
  (2) All non-cold candidate functions are now considered by ICP.
      Previously, only hot targets were considered.
These changes are expected to improve performance, with some large
Google benchmarks showing up to a 0.3% improvement.


Compare: https://github.com/llvm/llvm-project/compare/d8ef5127f298...95d89e0d2a07

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications