[all-commits] [llvm/llvm-project] 6855b9: [clang][deps] Properly capture the global module...

[Naveen Seth Hanig via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6855b9c598b3258e8c0e3edffe5458630a0b0105
      https://github.com/llvm/llvm-project/commit/6855b9c598b3258e8c0e3edffe5458630a0b0105
  Author: Naveen Seth Hanig <naveen.hanig at outlook.com>
  Date:   2025-07-19 (Sat, 19 Jul 2025)

  Changed paths:
    M clang/lib/Lex/DependencyDirectivesScanner.cpp
    M clang/lib/Lex/Preprocessor.cpp
    M clang/lib/Parse/Parser.cpp
    M clang/unittests/Lex/DependencyDirectivesScannerTest.cpp

  Log Message:
  -----------
    [clang][deps] Properly capture the global module and '\n' for all module directives (#148685)

Previously, the newline after a module directive was not properly
captured and printed by `clang::printDependencyDirectivesAsSource`.

According to P1857R3, each directive must, after skipping horizontal
whitespace, appear at the start of a logical line. Because the newline
after module directives was missing, this invalidated the following
line.
This fixes tests that were previously in violation of P1857R3,
including for Objective-C directives, which should also comply with
P1857R3.

This also ensures that the global module fragment `module;` is captured
by the dependency directives scanner.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications