[all-commits] [llvm/llvm-project] 8f4def: [libcxx][fstream][NFC] Make __failed helper lambda...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f4deff5d51ac190e056a6738018fc8aa3114151
      https://github.com/llvm/llvm-project/commit/8f4deff5d51ac190e056a6738018fc8aa3114151
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-07-17 (Thu, 17 Jul 2025)

  Changed paths:
    M libcxx/include/fstream

  Log Message:
  -----------
  [libcxx][fstream][NFC] Make __failed helper lambda a member function (#149390)

This patch makes the `__failed` lambda a member function on `fstream`.
This fixes two LLDB expression evaluation test failures that got
introduced with https://github.com/llvm/llvm-project/pull/147389:
```
16:22:51  ********************
16:22:51  Unresolved Tests (2):
16:22:51    lldb-api :: commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py
16:22:51    lldb-api :: commands/expression/import-std-module/list/TestListFromStdModule.py
```

The expression evaluator is asserting in the Clang parser:
```
Assertion failed: (capture_size() == Class->capture_size() && "Wrong number of captures"), function LambdaExpr, file ExprCXX.cpp, line 1277.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
```

Ideally we'd figure out why LLDB is falling over on this lambda. But to
unblock CI for now, make this a member function.

In the long run we should figure out the LLDB bug here so libc++ doesn't
need to care about whether it uses lambdas like this or not.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications