[all-commits] [llvm/llvm-project] a89e6f: Minor formatting fix in 'generate_feature_test_mac...

elsteveogrande via All-commits all-commits at lists.llvm.org
Wed Jul 16 08:20:15 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a89e6f66722713addd3a7a60377ddbb38add4702
      https://github.com/llvm/llvm-project/commit/a89e6f66722713addd3a7a60377ddbb38add4702
  Author: Steve O'Brien <steve at obrien.cc>
  Date:   2025-07-16 (Wed, 16 Jul 2025)

  Changed paths:
    M libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/any.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/array.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/bitset.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/cstdlib.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/cstring.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/expected.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/flat_map.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/flat_set.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/fstream.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/ios.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/list.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/map.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/mdspan.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/memory.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/memory_resource.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/mutex.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/new.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/numbers.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/numeric.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/optional.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/ostream.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/queue.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/random.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/ranges.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/ratio.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/regex.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/scoped_allocator.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/semaphore.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/set.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/shared_mutex.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/source_location.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/span.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/sstream.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/stack.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/stdatomic.h.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/stop_token.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/string.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/string_view.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/syncstream.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/thread.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/tuple.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/type_traits.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/typeinfo.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/unordered_map.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/unordered_set.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/utility.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/variant.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/vector.version.compile.pass.cpp
    M libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp
    M libcxx/utils/generate_feature_test_macro_components.py

  Log Message:
  -----------
  Minor formatting fix in 'generate_feature_test_macro_components' (#148889)

Fixes a small annoyance where generated files have a format which does
not agree with the one checked during `code-formatter` in CI.

For example `libcxx-generate-files` updates (among possibly others) the
`*.version.compile.pass.cpp` files. Previously these files contained an
extra newline which would fail the code format check. If you update that
file manually to remove just that extra trailing newline, then
`check-generated-output` will fail due to the file's contents differing
from what's expected.

Contains a number of changes: one actual change to the py script, and
lots of resulting whitespace changes.

My process for this was:
* Update `generate_feature_test_macro_components`: just remove an extra
newline which causes the code-format step to fail
* Run `$NINJA libcxx-generate-files` to rebuild all these
`.version.pass.cpp`'s
* Watch this PR's CI run to ensure things pass (i.e. this didn't break
things worse)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list