[all-commits] [llvm/llvm-project] f995bc: [lldb] Improve setting of program for filtering di...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f995bc802d06448a41846652d5e9a9f30f80a688
      https://github.com/llvm/llvm-project/commit/f995bc802d06448a41846652d5e9a9f30f80a688
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2025-07-16 (Wed, 16 Jul 2025)

  Changed paths:
    M lldb/examples/python/filter_disasm.py
    M lldb/test/Shell/Commands/command-disassemble-riscv32-bytes.s

  Log Message:
  -----------
  [lldb] Improve setting of program for filtering disassembly (#148823)

This changes the example command added in
https://github.com/llvm/llvm-project/pull/145793 so that the fdis
program does not have to be a single program name.

Doing so also means we can run the test on Windows where the program
needs to be "python.exe script_name".

I've changed "fdis set" to treat the rest of the command as the program.
Then store that as a list to be passed to subprocess. If we just use a
string, Python will think that "python.exe foo" is the name of an actual
program instead of a program and an argument to it.

This will still break if the paths have spaces in, but I'm trying to do
just enough to fix the test here without rewriting all the option
handling.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications