[all-commits] [llvm/llvm-project] 653872: [KeyInstr] Fix verifier check (#149043)

[Orlando Cazalet-Hyams via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 653872f782e1faaabc1da23769e6b35b10e74bde
      https://github.com/llvm/llvm-project/commit/653872f782e1faaabc1da23769e6b35b10e74bde
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-07-16 (Wed, 16 Jul 2025)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/test/DebugInfo/KeyInstructions/Generic/verify.ll

  Log Message:
  -----------
  [KeyInstr] Fix verifier check (#149043)

The verifier check was in the wrong place, meaning it wasn't actually
checking many instructions.

Fixing that causes a test failure (coro-dwarf-key-instrs.cpp) because
coros turn off the feature but still annotate instructions with the
metadata (which is a supported situation, but the verifier doesn't like
it, and it's hard to teach the verifier to like it).

Fix that by avoiding emitting any key instruction metadata if the
DISubprogram has opted out of key instructions.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications