[all-commits] [llvm/llvm-project] 76f1dd: [NFC][SemaHLSL] Remove check dependent on non-dete...

[Finn Plummer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 76f1ddc79cc00c78354bfae0a5cb08fae41dc4fd
      https://github.com/llvm/llvm-project/commit/76f1ddc79cc00c78354bfae0a5cb08fae41dc4fd
  Author: Finn Plummer <finn.c.plum at gmail.com>
  Date:   2025-07-14 (Mon, 14 Jul 2025)

  Changed paths:
    M clang/test/SemaHLSL/RootSignature-resource-ranges-err.hlsl

  Log Message:
  -----------
  [NFC][SemaHLSL] Remove check dependent on non-deterministic root element association (#148649)

- when there are duplicate (equivalent) `RangeInfo`s created we will
attempt to `llvm::sort` or `llvm::stable_sort` them, it does not appear
deterministic in which order they will be sorted (because they are
equivalent)

- when `DLLVM_ENABLE_EXSTENSIVE_CHECKS` is enabled, it appears to deal
with this tie-breaker sorting the list differently than when it is not
enabled, this causes one of the test cases to fail because the
diagnostic is produced, not in a different order, but with a different
root element associated with an identical `RangeInfo`

- functionally this makes no difference to the diagnostic being produced
and the removed test-case was added just as a nicety to demonstrate how
the diagnostics might look

- the test above the removed will correctly demonstrate that the
`SourceLocation` will be set to the correct column, and, the `-verify`
portion of this testcase will ensure that we still generate a diagnostic
for each duplicate

- therefore, it is safe to remove this portion of the test-case that can
have a non-deterministic association of root element

This resolves the build issues reported
[here](https://github.com/llvm/llvm-project/pull/147115#issuecomment-3069543491)
and
[here](https://github.com/llvm/llvm-project/pull/147800#issuecomment-3069797406)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications