[all-commits] [llvm/llvm-project] b9ccc0: [llvm][SystemZ] Set comment stream in SystemZDisas...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b9ccc0ca38dc1c0b8569c4a859bb258b79bb8bc8
      https://github.com/llvm/llvm-project/commit/b9ccc0ca38dc1c0b8569c4a859bb258b79bb8bc8
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2025-07-14 (Mon, 14 Jul 2025)

  Changed paths:
    M llvm/lib/Target/SystemZ/Disassembler/SystemZDisassembler.cpp
    M llvm/unittests/MC/SystemZ/CMakeLists.txt
    A llvm/unittests/MC/SystemZ/SystemZMCDisassemblerTest.cpp

  Log Message:
  -----------
  [llvm][SystemZ] Set comment stream in SystemZDisassembler::getInstruction (#148614)

This is done by other backends at the start of this function, for
example AArch64Disassembler::getInstruction. Not setting it means you
hit asserts in MCDisassembler::tryAddingSymbolicOperand and
MCDisassembler::tryAddingPcLoadReferenceComment when there is a
symbolizer set.

Which happened to me while debugging a SystemZ program using LLDB.

As the only good way to hit this path is from C++, I've copied X86's
disassembler unit tests and added just enough to hit an assert if the
comment stream is not set.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications