[all-commits] [llvm/llvm-project] 65d20b: [KeyInstr] Disable key-instructions for coroutine ...

[Jeremy Morse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 65d20bb0ab27f1b0078cc8811d02f7b47eb779bf
      https://github.com/llvm/llvm-project/commit/65d20bb0ab27f1b0078cc8811d02f7b47eb779bf
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2025-07-14 (Mon, 14 Jul 2025)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    A clang/test/DebugInfo/KeyInstructions/coro-dwarf-key-instrs.cpp

  Log Message:
  -----------
  [KeyInstr] Disable key-instructions for coroutine scopes (#147551)

At this time (immediately prior to llvm21 branching) we haven't
instrumented coroutine generation to identify the "key" instructions of
things like co_return and similar. This will lead to worse stepping
behaviours, as there won't be any key instruction for those lines.

This patch removes the key-instructions flag from the DISubprograms for
coroutines, which will cause AsmPrinter to use the "old" / existing
linetable stepping behaviour, avoiding a regression until we can
instrument these constructs.

(I'm going to post on discourse about whether this is a good idea or not
in a moment)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications