[all-commits] [llvm/llvm-project] 58c0bd: [mlir][Transforms] Dialect Conversion: `allowPatte...

Matthias Springer via All-commits all-commits at lists.llvm.org
Sun Jul 13 01:06:28 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 58c0bd196e566f20a6b5e35ff0b57db8fe6b34ca
      https://github.com/llvm/llvm-project/commit/58c0bd196e566f20a6b5e35ff0b57db8fe6b34ca
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-07-13 (Sun, 13 Jul 2025)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms] Dialect Conversion: `allowPatternRollback` to check foldings (#148394)

When an operation is folded to an attribute, the attribute must be
materialized as a constant operation. That operation must then be
legalized. If such a legalization fails, the entire folding is rolled
back. This is not supported in a One-Shot Dialect Conversion. (Support
for rolling back foldings could be added at a later point of time.)

This commit improves the `allowPatternRollback` flag handling, such that
a fatal error is reported when a folder is attempted to be rolled back.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list