[all-commits] [llvm/llvm-project] 67db34: [mlir][Transforms][NFC] Dialect Conversion: Earlie...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 67db34863cefb4ddb71babbe22416c89cf743564
      https://github.com/llvm/llvm-project/commit/67db34863cefb4ddb71babbe22416c89cf743564
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-07-12 (Sat, 12 Jul 2025)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] Dialect Conversion: Earlier `isIgnored` check (#148360)

When legalizing an operation, the conversion driver skips "ignored" ops.
Ops are ignored if they are inside of a recursively legal operation or
if they were erased.

This commit moves the "is ignored" check a bit earlier: it is now
checked before checking if the op is recursively legal. This is in
preparation of the One-Shot Dialect Conversion refactoring: erased ops
should not be accessed, not even for checking recursive legality.

This commit is NFC: When an op is erased, it is added to the set of
ignored ops and we don't want to process it, regardless of legality.
Nested ops are also added to the set of ignored ops when erasing an
enclosing op.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications