[all-commits] [llvm/llvm-project] 1cd216: [SCEV] Take global variable linkage into account w...

[Arthur Eubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1cd2165afe18cd35eea443b431964ca334c35c21
      https://github.com/llvm/llvm-project/commit/1cd2165afe18cd35eea443b431964ca334c35c21
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2025-07-11 (Fri, 11 Jul 2025)

  Changed paths:
    M llvm/lib/Analysis/ScalarEvolution.cpp
    M llvm/unittests/Analysis/ScalarEvolutionTest.cpp

  Log Message:
  -----------
  [SCEV] Take global variable linkage into account when comparing values (#148071)

Current the comparator is inconsistent when we have two external globals
and one internal globals due to
```
    if (IsGVNameSemantic(LGV) && IsGVNameSemantic(RGV))
      return LGV->getName().compare(RGV->getName());
```

The internal global compares equal to (not strictly less than) the
external globals, but the external globals are not equal.

Fixes #147862.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications