[all-commits] [llvm/llvm-project] 95166f: remove confusing hlsl_unexpected_end_of_params dia...

[Finn Plummer via All-commits]

  Branch: refs/heads/users/inbelic/pr-147800
  Home:   https://github.com/llvm/llvm-project
  Commit: 95166f5e2bfb2816ce39d3abd1823486742109bd
      https://github.com/llvm/llvm-project/commit/95166f5e2bfb2816ce39d3abd1823486742109bd
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/test/SemaHLSL/RootSignature-err.hlsl
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  remove confusing hlsl_unexpected_end_of_params diagnostic

- It has been noted more than once that this diagnostic is confusing and
misleading. It can be more concise


  Commit: 24a2bea7fa745f3909f632369e8f8aaa7fff0b2a
      https://github.com/llvm/llvm-project/commit/24a2bea7fa745f3909f632369e8f8aaa7fff0b2a
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/test/SemaHLSL/RootSignature-err.hlsl
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  add invalid_param diagnostic to differentiate between missing comma vs invalid token


  Commit: 4edb7fa000026935accfd993ff4ca1f4eed68c2e
      https://github.com/llvm/llvm-project/commit/4edb7fa000026935accfd993ff4ca1f4eed68c2e
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/test/SemaHLSL/RootSignature-err.hlsl

  Log Message:
  -----------
  keep test of missing comma


  Commit: b17b40c5b6f8e68a83f8ad7cedc3c0a51589c945
      https://github.com/llvm/llvm-project/commit/b17b40c5b6f8e68a83f8ad7cedc3c0a51589c945
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/test/SemaHLSL/RootSignature-err.hlsl

  Log Message:
  -----------
  audit use of err_expected_after

the order of the parameters is switched as opposed to either and this
was not caught in the unit tests


  Commit: bbd8921c962a6982f10881257a3ec37d6f2d2b90
      https://github.com/llvm/llvm-project/commit/bbd8921c962a6982f10881257a3ec37d6f2d2b90
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  nfc: prepare to extend diagnostic to values as well


  Commit: c3a4642c5869324a88b70ed867b0ee62da4ff8e7
      https://github.com/llvm/llvm-project/commit/c3a4642c5869324a88b70ed867b0ee62da4ff8e7
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/test/SemaHLSL/RootSignature-err.hlsl
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  extend invalid_token diagnostic to enum parsing


  Commit: b32343063a62681e3aefd46d1b21018c84476e26
      https://github.com/llvm/llvm-project/commit/b32343063a62681e3aefd46d1b21018c84476e26
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/test/SemaHLSL/RootSignature-err.hlsl

  Log Message:
  -----------
  extend invalid_token diagnostic to flag parsing


  Commit: 8187a65789e8776513e9b3ea9756da62fddd4ad7
      https://github.com/llvm/llvm-project/commit/8187a65789e8776513e9b3ea9756da62fddd4ad7
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/test/SemaHLSL/RootSignature-err.hlsl

  Log Message:
  -----------
  extend invalid_token diagnostic to RootFlags enum


  Commit: 6d48044edf53d679d9c6a36d88219b401d05944d
      https://github.com/llvm/llvm-project/commit/6d48044edf53d679d9c6a36d88219b401d05944d
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/test/SemaHLSL/RootSignature-err.hlsl
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  improve err_expected to err_expected_either at end of params


  Commit: 522b08467c40282feb8566b648b8c16f86232942
      https://github.com/llvm/llvm-project/commit/522b08467c40282feb8566b648b8c16f86232942
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  improve unit test coverge of invalid values


  Commit: 70448a3e3daae9ebac71df5b995bc93025b7a644
      https://github.com/llvm/llvm-project/commit/70448a3e3daae9ebac71df5b995bc93025b7a644
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  improve unit test coverage of invalid parameters


Compare: https://github.com/llvm/llvm-project/compare/95166f5e2bfb%5E...70448a3e3daa

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications