[all-commits] [llvm/llvm-project] 420e2f: [DirectX] Add missing verifications during `valida...

[Finn Plummer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 420e2f584de21385f07965f78458119ede6768d8
      https://github.com/llvm/llvm-project/commit/420e2f584de21385f07965f78458119ede6768d8
  Author: Finn Plummer <finn.c.plum at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M llvm/include/llvm/Frontend/HLSL/RootSignatureValidations.h
    M llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp
    M llvm/lib/Target/DirectX/DXILRootSignature.cpp
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-DescriptorTable-AllValidFlagCombinationsV1.ll
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-DescriptorTable-Invalid-Flag.ll
    A llvm/test/CodeGen/DirectX/ContainerData/RootSignature-DescriptorTable-Invalid-NumDescriptors.ll
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-DescriptorTable-Invalid-RangeType.ll
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-DescriptorTable-Invalid-RegisterSpace.ll
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-DescriptorTable.ll
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-Parameters.ll
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-RootDescriptor-Invalid-Flags.ll
    A llvm/test/CodeGen/DirectX/ContainerData/RootSignature-RootDescriptor-Invalid-Multiple-Flags.ll
    M llvm/test/CodeGen/DirectX/ContainerData/RootSignature-RootDescriptor_V1.ll

  Log Message:
  -----------
  [DirectX] Add missing verifications during `validate` of `DXILRootSignature` (#147111)

This pr resolves some discrepancies in verification during `validate` in
`DXILRootSignature.cpp`.

Note: we don't add a backend test for version 1.0 flag values because it
treats the struct as though there is no flags value. However, this will
be used when we use the verifications in the frontend.

- Updates `verifyDescriptorFlag` to check for valid flags based on
version, as reflected [here](https://github.com/llvm/wg-hlsl/pull/297)
- Add test to demonstrate updated flag verifications
- Adds `verifyNumDescriptors` to the validation of `DescriptorRange`s
- Add a test to demonstrate `numDescriptors` verification
- Updates a number of tests that mistakenly had an invalid
`numDescriptors` specified

Resolves: https://github.com/llvm/llvm-project/issues/147107



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications