[all-commits] [llvm/llvm-project] 23b4f4: [NFC][TableGen] Change DecoderEmitter `insertBits`...

Rahul Joshi via All-commits all-commits at lists.llvm.org
Wed Jul 9 08:56:29 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23b4f4eb9b15e0c3a8d86d9c0857075afcfc7fe3
      https://github.com/llvm/llvm-project/commit/23b4f4eb9b15e0c3a8d86d9c0857075afcfc7fe3
  Author: Rahul Joshi <rjoshi at nvidia.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h
    M llvm/utils/TableGen/DecoderEmitter.cpp

  Log Message:
  -----------
  [NFC][TableGen] Change DecoderEmitter `insertBits` to use integer types only (#147613)

The `insertBits` templated function generated by DecoderEmitter is
called with variable `tmp` of type `TmpType` which is:

```
using TmpType = std::conditional_t<std::is_integral<InsnType>::value, InsnType, uint64_t>;
```

That is, `TmpType` is always an integral type. Change the generated
`insertBits` to be valid only for integer types, and eliminate the
unused `insertBits` function from `DecoderUInt128` in
AMDGPUDisassembler.h

Additionally, drop some of the requirements `InsnType` must support as
they no longer seem to be required.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list