[all-commits] [llvm/llvm-project] 1e6dd8: [lldb][test] Merge MSVC STL std::(u8)string tests ...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1e6dd8c1e47f90f33b4ade4a13309d978212c297
      https://github.com/llvm/llvm-project/commit/1e6dd8c1e47f90f33b4ade4a13309d978212c297
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string/TestDataFormatterStdString.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string/main.cpp
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/Makefile
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/TestDataFormatterStdU8String.py
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/main.cpp
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/string/Makefile
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/string/TestDataFormatterMsvcStlString.py
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/string/main.cpp
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/u8string/Makefile
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/u8string/TestDataFormatterMsvcStlU8String.py
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/u8string/main.cpp

  Log Message:
  -----------
  [lldb][test] Merge MSVC STL std::(u8)string tests into generic directory (#147525)

Now that most STL formatter tests have been moved to `generic`. Do the
same for the MSVC tests (which are currently just for `std::string`).
The `std::string` test was mostly the same (MSVC just had 1 additional
check, which I moved over).

We also only tested `u8string` with MSVC. So i moved those into
`generic` as-is. I kept it separate from the existing std::string tests
since it requires c++20.

The tests are currently failing for libc++ and libstdc++ because MSVC
had a test case which checked that:
```
  std::string overwritten_zero("abc");
  const_cast<char *>(overwritten_zero.data())[3] = 'd';
```
prints as `"abc"`. But libc++ and libstdc++ print it as `"abcd"` (which
seems like the more correct thing to do?)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications