[all-commits] [llvm/llvm-project] 0462b0: AtomicExpand: Stop using report_fatal_error

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jul 8 18:08:13 PDT 2025


  Branch: refs/heads/users/arsenm/atomic-expand/stop-using-report-fatal-error
  Home:   https://github.com/llvm/llvm-project
  Commit: 0462b06217beb3727f5024a85add5606fcf232ed
      https://github.com/llvm/llvm-project/commit/0462b06217beb3727f5024a85add5606fcf232ed
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-07-09 (Wed, 09 Jul 2025)

  Changed paths:
    M llvm/include/llvm/IR/RuntimeLibcalls.td
    M llvm/lib/CodeGen/AtomicExpandPass.cpp
    R llvm/test/CodeGen/AMDGPU/atomic-oversize.ll
    A llvm/test/CodeGen/AMDGPU/unsupported-atomics.ll
    A llvm/test/CodeGen/NVPTX/atomicrmw-expand.err.ll
    M llvm/test/CodeGen/NVPTX/atomicrmw-expand.ll
    R llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-fp128.ll
    R llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-i128.ll
    M llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-mmra.ll
    M llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomicrmw-fp-vector.ll
    M llvm/test/Transforms/AtomicExpand/AMDGPU/unaligned-atomic.ll

  Log Message:
  -----------
  AtomicExpand: Stop using report_fatal_error

Emit a context error and delete the instruction. This
allows removing the AMDGPU hack where some atomic libcalls
are falsely added. NVPTX also later copied the same hack,
so remove it there too.

For now just emit the generic error, which is not good. It's
missing any useful context information (despite taking the instruction).
It's also confusing in the failed atomicrmw case, since it's reporting
failure at the intermediate failed cmpxchg instead of the original
atomicrmw.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list