[all-commits] [llvm/llvm-project] d9b208: [lldb][test] Combine libstdc++ and libc++ std::var...

Michael Buch via All-commits all-commits at lists.llvm.org
Tue Jul 8 06:09:54 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d9b208b4d31d863c86e27e8889a521a82385f1a7
      https://github.com/llvm/llvm-project/commit/d9b208b4d31d863c86e27e8889a521a82385f1a7
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/Makefile
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/main.cpp
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefile
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/invalid-variant/Makefile
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/invalid-variant/TestDataFormatterInvalidStdVariant.py
    A lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/invalid-variant/main.cpp
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/variant/Makefile
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/variant/TestDataFormatterLibStdcxxVariant.py
    R lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/variant/main.cpp

  Log Message:
  -----------
  [lldb][test] Combine libstdc++ and libc++ std::variant tests into generic test (#147253)

This combines the libc++ and libstdc++ test cases. The libstdc++ test
had an additional test-case for "reference to typedef". So I added those
to the generic test. The rest of the tests was the same as libc++.

I also moved the test-case for checking invalid variant indexes into a
separate libstdcpp test because it relied on the layout of the libstdc++
type. We should probably rewrite it in the "simulator" style. But for
now I just moved it.

This also removes some redundant checks for libc++ versions and
existence of the `variant` header, which at this point should be
available anywhere these tests are run.

Split out from https://github.com/llvm/llvm-project/pull/146740



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list