[all-commits] [llvm/llvm-project] 406324: RuntimeLibcalls: Account for Triple default except...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Jul 7 21:05:39 PDT 2025


  Branch: refs/heads/users/arsenm/runtime-libcalls/set-default-exception-handling-from-triple
  Home:   https://github.com/llvm/llvm-project
  Commit: 406324769e4110601fb29f66342c6796c1f01ec8
      https://github.com/llvm/llvm-project/commit/406324769e4110601fb29f66342c6796c1f01ec8
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M llvm/include/llvm/IR/RuntimeLibcalls.h

  Log Message:
  -----------
  RuntimeLibcalls: Account for Triple default exception handling

Previously we were taking the raw TargetOptions exception mode.
This only works correctly for the TargetLowering usage, when
the -exception-model flag is explicitly used.

The interface isn't great, and interprets none to both mean use
target default and unsupported, such that it's not possible to
opt-out of exceptions on targets that report a non-none default.

We also still get the wrong mode in the linker usecase of
RuntimeLibcalls since it doesn't have the TargetMachine. But at
least wrongly being the default is an improvement over being unset.

I'm not really sure how to write a test for this.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list