[all-commits] [llvm/llvm-project] 45509a: M68, test: Remove CHECK lines for MCAsmStreamer's f...

Fangrui Song via All-commits all-commits at lists.llvm.org
Fri Jul 4 23:06:55 PDT 2025


  Branch: refs/heads/users/MaskRay/spr/mc-centralize-x86-pc-relative-fixup-adjustment-in-mcassembler
  Home:   https://github.com/llvm/llvm-project
  Commit: 45509a8c6d2d923b6abb4d38175718612ea58ba7
      https://github.com/llvm/llvm-project/commit/45509a8c6d2d923b6abb4d38175718612ea58ba7
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/test/MC/M68k/Relaxations/PIC/branch.s
    M llvm/test/MC/M68k/Relaxations/PIC/branch32.s
    M llvm/test/MC/M68k/Relaxations/branch32.s
    M llvm/test/MC/M68k/Relocations/PIC/data-abs.s
    M llvm/test/MC/M68k/Relocations/PIC/data-gotoff.s
    M llvm/test/MC/M68k/Relocations/PIC/data-gotpcrel.s
    M llvm/test/MC/M68k/Relocations/PIC/data-pc-rel.s
    M llvm/test/MC/M68k/Relocations/PIC/text-plt.s
    M llvm/test/MC/M68k/Relocations/data-abs.s
    M llvm/test/MC/M68k/Relocations/data-gotoff.s
    M llvm/test/MC/M68k/Relocations/data-gotpcrel.s
    M llvm/test/MC/M68k/Relocations/data-pc-rel.s
    M llvm/test/MC/M68k/Relocations/text-plt.s

  Log Message:
  -----------
  M68,test: Remove CHECK lines for MCAsmStreamer's fixup output

The fixup output is a debug aid and should not be used to test
target-specific relocation generation implementation. The llvm-mc
-filetype=obj output is what truly matters.

The FIXUP code was likely copied from RISC-V, which has been cleaned up.


  Commit: 5760c064bbe72b57ce8bb5c6f431f0339abac37a
      https://github.com/llvm/llvm-project/commit/5760c064bbe72b57ce8bb5c6f431f0339abac37a
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/test/MC/M68k/Control/branch-pc-rel.s
    M llvm/test/MC/M68k/Control/bsr.s
    M llvm/test/MC/M68k/Control/bsr32.s
    M llvm/test/MC/M68k/Control/call-pc-rel.s
    M llvm/test/MC/M68k/Relocations/tls.s
    M llvm/test/MC/M68k/pc-rel.s

  Log Message:
  -----------
  M68,test: Remove CHECK lines for MCAsmStreamer's fixup output

The fixup output is a debug aid and should not be used to test
target-specific relocation generation implementation. The llvm-mc
-filetype=obj output is what truly matters.

The FIXUP code was likely copied from RISC-V, which has been cleaned up.


  Commit: c05593b1908ea1f8405b9f55951b48a990fcb404
      https://github.com/llvm/llvm-project/commit/c05593b1908ea1f8405b9f55951b48a990fcb404
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/M68k/MCTargetDesc/M68kFixupKinds.h
    M llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp

  Log Message:
  -----------
  M68: Replace FK_PCRel_ with FK_Data_+PCRel


  Commit: ae3d3135277a34fbaba75bc2eec5fb8bfd308b64
      https://github.com/llvm/llvm-project/commit/ae3d3135277a34fbaba75bc2eec5fb8bfd308b64
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/VE/MCTargetDesc/VEAsmBackend.cpp
    M llvm/lib/Target/VE/MCTargetDesc/VEELFObjectWriter.cpp

  Log Message:
  -----------
  VE: Remove dead FK_PCRel_* code


  Commit: 22c590bd3c75ccb6b443e074e4df2c82771a96eb
      https://github.com/llvm/llvm-project/commit/22c590bd3c75ccb6b443e074e4df2c82771a96eb
  Author: Yingwei Zheng <dtcxzyw2333 at gmail.com>
  Date:   2025-07-05 (Sat, 05 Jul 2025)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVInstrInfo.td
    M llvm/test/CodeGen/RISCV/GlobalISel/float-intrinsics.ll
    M llvm/test/CodeGen/RISCV/float-intrinsics.ll
    M llvm/test/CodeGen/RISCV/i32-icmp.ll
    M llvm/test/CodeGen/RISCV/i64-icmp.ll
    M llvm/test/CodeGen/RISCV/overflow-intrinsics.ll

  Log Message:
  -----------
  [RISCV][ISel] Optimize setcc with mask test idioms (#147015)

As we are converting more comparisons/differences of pointers into those
of offsets in InstCombine, the mask test idiom `icmp eq/ne (and X,
Mask), 0` may be more common in real-world programs.

This patch eliminates unnecessary srli instructions for this pattern. We
have a similar optimization for `RISCVISD::SELECT_CC/BR_CC`:
https://github.com/llvm/llvm-project/blob/a89e232058a29260eb9bfe77b862715ce875f962/llvm/lib/Target/RISCV/RISCVISelLowering.cpp#L2416-L2446

However, I cannot reuse the function `translateSetCCForBranch` due to
some regressions caused by other DAGCombiner folds:
https://github.com/llvm/llvm-project/compare/main...dtcxzyw:llvm-project:rv-mask-test.
So this patch defers the transformation to ISel.


  Commit: c20379198c7fb66b9514d21ae1e07b0705e3e6fa
      https://github.com/llvm/llvm-project/commit/c20379198c7fb66b9514d21ae1e07b0705e3e6fa
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/MC/MCAsmStreamer.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFObjectWriter.cpp
    M llvm/test/MC/ELF/mc-dump.s

  Log Message:
  -----------
  X86: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag

We will unify the generic fixup kinds FK_Data_ and FK_PCRel_. A
FK_PCRel_ kind is essentially the corresponding FK_Data_ fixup with the
PCRel flag set.


  Commit: 66952f7b2d614996cca1ed86968b90d0e7293d2f
      https://github.com/llvm/llvm-project/commit/66952f7b2d614996cca1ed86968b90d0e7293d2f
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/M68k/MCTargetDesc/M68kELFObjectWriter.cpp

  Log Message:
  -----------
  M68k: Remove unused deprecated FK_PCRel_


  Commit: a26f8f234843965f7e5c15ae14c599c7ab457da1
      https://github.com/llvm/llvm-project/commit/a26f8f234843965f7e5c15ae14c599c7ab457da1
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/BPF/MCTargetDesc/BPFAsmBackend.cpp
    M llvm/lib/Target/BPF/MCTargetDesc/BPFELFObjectWriter.cpp
    M llvm/lib/Target/BPF/MCTargetDesc/BPFMCCodeEmitter.cpp

  Log Message:
  -----------
  BPF: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag

We will unify the generic fixup kinds FK_Data_ and FK_PCRel_. A
FK_PCRel_ kind is essentially the corresponding FK_Data_ fixup with the
PCRel flag set.


  Commit: 970ed59e031d26dcba244ccdf5ba60628c4279cd
      https://github.com/llvm/llvm-project/commit/970ed59e031d26dcba244ccdf5ba60628c4279cd
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/CSKY/MCTargetDesc/CSKYELFObjectWriter.cpp

  Log Message:
  -----------
  CSKY: Remove unused deprecated FK_PCRel_4


  Commit: abaa55d937e5c4b72fa935d27d8f9a15f0a8f502
      https://github.com/llvm/llvm-project/commit/abaa55d937e5c4b72fa935d27d8f9a15f0a8f502
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFObjectWriter.cpp
    M llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp

  Log Message:
  -----------
  COFF: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag

We will unify the generic fixup kinds FK_Data_ and FK_PCRel_. A
FK_PCRel_ kind is essentially the corresponding FK_Data_ fixup with the
PCRel flag set.


  Commit: 49c91ec6f17983d8bd1fb3fb0a79e79eccb8fed7
      https://github.com/llvm/llvm-project/commit/49c91ec6f17983d8bd1fb3fb0a79e79eccb8fed7
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/Hexagon/MCTargetDesc/HexagonELFObjectWriter.cpp

  Log Message:
  -----------
  Hexagon: Remove dead deprecated FK_PCRel_4 use


  Commit: 158fa4ae8389bbeff22438fca14764fdfa119bce
      https://github.com/llvm/llvm-project/commit/158fa4ae8389bbeff22438fca14764fdfa119bce
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCCodeEmitter.cpp

  Log Message:
  -----------
  AMDGPU: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag

We will unify the generic fixup kinds FK_Data_ and FK_PCRel_. A
FK_PCRel_ kind is essentially the corresponding FK_Data_ fixup with the
PCRel flag set.


  Commit: 32f83d38bd624885a782cb8816ae42081a3fb1a0
      https://github.com/llvm/llvm-project/commit/32f83d38bd624885a782cb8816ae42081a3fb1a0
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/include/llvm/MC/MCFixup.h
    M llvm/lib/MC/MCAsmBackend.cpp
    M llvm/lib/Target/Hexagon/MCTargetDesc/HexagonAsmBackend.cpp
    M llvm/test/CodeGen/Mips/llvm-ir/load.ll
    M llvm/test/CodeGen/Mips/llvm-ir/store.ll

  Log Message:
  -----------
  MCFixup: Remove FK_PCRel_

The generic FK_Data_ fixup kinds handle both absolute and PC-relative
fixups. ELFObjectWriter sets IsPCRel to true for `.long foo-.`, so the
backend has to handle PC-relative FK_Data_.

However, the existence of FK_PCRel_ encouraged backends to implement it
as a separate fixup type, leading to redundant and error-prone code.

Removing FK_PCRel_ simplifies the overall fixup mechanism.


  Commit: e42b8971721f7d19f4d8b828eda9104fae60f619
      https://github.com/llvm/llvm-project/commit/e42b8971721f7d19f4d8b828eda9104fae60f619
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-07-04 (Fri, 04 Jul 2025)

  Changed paths:
    M llvm/include/llvm/MC/MCFixup.h
    M llvm/lib/MC/MCAsmBackend.cpp
    M llvm/lib/MC/MCAsmStreamer.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFObjectWriter.cpp
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCCodeEmitter.cpp
    M llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
    M llvm/lib/Target/BPF/MCTargetDesc/BPFAsmBackend.cpp
    M llvm/lib/Target/BPF/MCTargetDesc/BPFELFObjectWriter.cpp
    M llvm/lib/Target/BPF/MCTargetDesc/BPFMCCodeEmitter.cpp
    M llvm/lib/Target/CSKY/MCTargetDesc/CSKYELFObjectWriter.cpp
    M llvm/lib/Target/Hexagon/MCTargetDesc/HexagonAsmBackend.cpp
    M llvm/lib/Target/Hexagon/MCTargetDesc/HexagonELFObjectWriter.cpp
    M llvm/lib/Target/M68k/MCTargetDesc/M68kELFObjectWriter.cpp
    M llvm/lib/Target/M68k/MCTargetDesc/M68kFixupKinds.h
    M llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp
    M llvm/lib/Target/RISCV/RISCVInstrInfo.td
    M llvm/lib/Target/VE/MCTargetDesc/VEAsmBackend.cpp
    M llvm/lib/Target/VE/MCTargetDesc/VEELFObjectWriter.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFObjectWriter.cpp
    M llvm/test/CodeGen/Mips/llvm-ir/load.ll
    M llvm/test/CodeGen/Mips/llvm-ir/store.ll
    M llvm/test/CodeGen/RISCV/GlobalISel/float-intrinsics.ll
    M llvm/test/CodeGen/RISCV/float-intrinsics.ll
    M llvm/test/CodeGen/RISCV/i32-icmp.ll
    M llvm/test/CodeGen/RISCV/i64-icmp.ll
    M llvm/test/CodeGen/RISCV/overflow-intrinsics.ll
    M llvm/test/MC/ELF/mc-dump.s
    M llvm/test/MC/M68k/Control/branch-pc-rel.s
    M llvm/test/MC/M68k/Control/bsr.s
    M llvm/test/MC/M68k/Control/bsr32.s
    M llvm/test/MC/M68k/Control/call-pc-rel.s
    M llvm/test/MC/M68k/Relaxations/PIC/branch.s
    M llvm/test/MC/M68k/Relaxations/PIC/branch32.s
    M llvm/test/MC/M68k/Relaxations/branch32.s
    M llvm/test/MC/M68k/Relocations/PIC/data-abs.s
    M llvm/test/MC/M68k/Relocations/PIC/data-gotoff.s
    M llvm/test/MC/M68k/Relocations/PIC/data-gotpcrel.s
    M llvm/test/MC/M68k/Relocations/PIC/data-pc-rel.s
    M llvm/test/MC/M68k/Relocations/PIC/text-plt.s
    M llvm/test/MC/M68k/Relocations/data-abs.s
    M llvm/test/MC/M68k/Relocations/data-gotoff.s
    M llvm/test/MC/M68k/Relocations/data-gotpcrel.s
    M llvm/test/MC/M68k/Relocations/data-pc-rel.s
    M llvm/test/MC/M68k/Relocations/text-plt.s
    M llvm/test/MC/M68k/Relocations/tls.s
    M llvm/test/MC/M68k/pc-rel.s

  Log Message:
  -----------
  rebase

Created using spr 1.3.5-bogner


Compare: https://github.com/llvm/llvm-project/compare/34ce16ce719b...e42b8971721f

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list