[all-commits] [llvm/llvm-project] 943804: [IR2Vec] Simplifying creation of Embedder (#143999)

[S. VenkataKeerthy via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9438048816892229445b4db352fceb487a83e7f2
      https://github.com/llvm/llvm-project/commit/9438048816892229445b4db352fceb487a83e7f2
  Author: S. VenkataKeerthy <31350914+svkeerthy at users.noreply.github.com>
  Date:   2025-06-30 (Mon, 30 Jun 2025)

  Changed paths:
    M llvm/docs/MLGO.rst
    M llvm/include/llvm/Analysis/IR2Vec.h
    M llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp
    M llvm/lib/Analysis/IR2Vec.cpp
    M llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp
    M llvm/unittests/Analysis/IR2VecTest.cpp

  Log Message:
  -----------
  [IR2Vec] Simplifying creation of Embedder (#143999)

This change simplifies the API by removing the error handling complexity. 

- Changed `Embedder::create()` to return `std::unique_ptr<Embedder>` directly instead of `Expected<std::unique_ptr<Embedder>>`
- Updated documentation and tests to reflect the new API
- Added death test for invalid IR2Vec kind in debug mode
- In release mode, simply returns nullptr for invalid kinds instead of creating an error

(Tracking issue - #141817)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications