[all-commits] [llvm/llvm-project] 183acd: [GlobalOpt] Revert global widening transform (#144...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 183acdd27985afd332463e3d9fd4a2ca46d85cf1
      https://github.com/llvm/llvm-project/commit/183acdd27985afd332463e3d9fd4a2ca46d85cf1
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2025-06-30 (Mon, 30 Jun 2025)

  Changed paths:
    M llvm/lib/Transforms/IPO/GlobalOpt.cpp
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-dest-non-array.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-global-dest.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-non-byte-array.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-non-const-global.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-string-multi-use.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-strings-1.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-strings-2.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-strings-lengths-dont-match.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-strings-more-than-64-bytes.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-strings-ptrtoint.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-strings-struct-test.ll
    R llvm/test/Transforms/GlobalOpt/ARM/arm-widen-strings-volatile.ll
    R llvm/test/Transforms/GlobalOpt/ARM/lit.local.cfg

  Log Message:
  -----------
  [GlobalOpt] Revert global widening transform (#144652)

Partially reverts e37d736def5b95a2710f92881b5fc8b0494d8a05.

The transform has a number of correctness and code quality issues, and
will benefit from a from-scratch re-review more than incremental fixes.

The correctness issues are hinted at in
https://github.com/llvm/llvm-project/pull/144641, but I think it needs a
larger rework to stop working on ArrayTypes and the implementation could
use some other improvements (like callInstIsMemcpy should just be
`dyn_cast<MemCpyInst>`). I can comment in more detail on a resubmission
of the patch.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications