[all-commits] [llvm/llvm-project] 2e7aa7: [mlir][tosa] Add custom operand getters for select...

[Luke Hutton via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2e7aa7ead6808047df2b7b56bfc725ffc3685e43
      https://github.com/llvm/llvm-project/commit/2e7aa7ead6808047df2b7b56bfc725ffc3685e43
  Author: Luke Hutton <luke.hutton at arm.com>
  Date:   2025-06-30 (Mon, 30 Jun 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
    M mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
    M mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
    M mlir/lib/Dialect/Tosa/Transforms/TosaMakeBroadcastable.cpp
    M mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp

  Log Message:
  -----------
  [mlir][tosa] Add custom operand getters for select op (#145921)

The select op has 3 inputs: input1, input2, input3 to according to the
tosa specification. However, use of getInput1(), getInput2() and
getInput3() in the codebase can be confusing and hinder readability.
This commit adds custom getters to help improve readability:
  - input1 -> getPred()
  - input2 -> getOnTrue()
  - input3 -> getOnFalse()

They should be preferred as they are more descriptive, however, the ODS
generated getters (getInputX()) may still be used.

Unfortunately the custom getters don't propagate to Adaptors such as
`FoldAdaptor`, so the ODS generated getters must be used.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications