[all-commits] [llvm/llvm-project] 735412: [KeyInstr] Use DISubprogram's is-key-instructions-...

[Orlando Cazalet-Hyams via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7354123c34e658e990559a36b1ac7eb0b671e317
      https://github.com/llvm/llvm-project/commit/7354123c34e658e990559a36b1ac7eb0b671e317
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-30 (Mon, 30 Jun 2025)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    A llvm/test/DebugInfo/KeyInstructions/X86/dwarf-inline-modes.mir

  Log Message:
  -----------
  [KeyInstr] Use DISubprogram's is-key-instructions-on flag at DWARF emission (#144104)

Patch 2/4 adding bitcode support.

A non-key-instructions function inlined into a key-instructions function uses
non-key-instructions is_stmt placement (without `findForceIsStmtInstrs`).

A key-instructions function inlined into a non-key-instructions function
currently results in falling back to non-key-instructions for the inlined scope
too.

Both of these concessions (not using `findForceIsStmtInstrs` in the 1st case,
and not using Key Instructions for the inlined scope in the 2nd) are for
performance reasons; to do the right thing we'd need to run both
`findForceIsStmtInstrs` and `computeKeyInstructions` - in case that's
controversial I've got a separate PR for that: PR 144103.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications