[all-commits] [llvm/llvm-project] ec48d1: Fix a bug in the breakpoint ID verifier in Command...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec48d15b2003253e26d9f902b252f92e89a114e2
      https://github.com/llvm/llvm-project/commit/ec48d15b2003253e26d9f902b252f92e89a114e2
  Author: jimingham <jingham at apple.com>
  Date:   2025-06-26 (Thu, 26 Jun 2025)

  Changed paths:
    M lldb/source/Commands/CommandObjectBreakpoint.cpp
    A lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/Makefile
    A lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/TestLocationsAfterRebuild.py
    A lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/main.c
    A lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/second_main.c
    A lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/third_main.c

  Log Message:
  -----------
  Fix a bug in the breakpoint ID verifier in CommandObjectBreakpoint. (#145994)

It was assuming that for any location M.N, N was always less than the
number of breakpoint locations. But if you rebuild the target and rerun
multiple times, when the section backing one of the locations is no
longer valid, we remove the location, but we don't reuse the ID. So you
can have a breakpoint that only has location 1.3. The num_locations
check would say that was an invalid location.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications