[all-commits] [llvm/llvm-project] cbf781: [NFC][DebugInfo][DWARF] Create new low-level dwarf...

[Sterling-Augustine via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cbf781f0bdf2f680abbe784faedeefd6f84c246e
      https://github.com/llvm/llvm-project/commit/cbf781f0bdf2f680abbe784faedeefd6f84c246e
  Author: Sterling-Augustine <56981066+Sterling-Augustine at users.noreply.github.com>
  Date:   2025-06-26 (Thu, 26 Jun 2025)

  Changed paths:
    M bolt/include/bolt/Core/DIEBuilder.h
    M bolt/lib/Core/CMakeLists.txt
    M bolt/lib/Core/DIEBuilder.cpp
    M bolt/lib/Core/DebugNames.cpp
    M bolt/lib/Rewrite/CMakeLists.txt
    M bolt/lib/Rewrite/DWARFRewriter.cpp
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/source/Symbol/UnwindPlan.cpp
    M lldb/unittests/Symbol/PostfixExpressionTest.cpp
    M lldb/unittests/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpressionTests.cpp
    M llvm/include/llvm/DWARFLinker/AddressesMap.h
    M llvm/include/llvm/DWARFLinker/Classic/DWARFLinker.h
    M llvm/include/llvm/DWARFLinker/DWARFLinkerBase.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFCFIPrinter.h
    R llvm/include/llvm/DebugInfo/DWARF/DWARFCFIProgram.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
    R llvm/include/llvm/DebugInfo/DWARF/DWARFDataExtractorSimple.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
    R llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
    A llvm/include/llvm/DebugInfo/DWARF/DWARFExpressionPrinter.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
    A llvm/include/llvm/DebugInfo/DWARF/LowLevel/DWARFCFIProgram.h
    A llvm/include/llvm/DebugInfo/DWARF/LowLevel/DWARFDataExtractorSimple.h
    A llvm/include/llvm/DebugInfo/DWARF/LowLevel/DWARFExpression.h
    M llvm/lib/CodeGen/AsmPrinter/CMakeLists.txt
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/DWARFLinker/Classic/CMakeLists.txt
    M llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp
    M llvm/lib/DWARFLinker/Classic/DWARFLinkerCompileUnit.cpp
    M llvm/lib/DebugInfo/DWARF/CMakeLists.txt
    M llvm/lib/DebugInfo/DWARF/DWARFCFIPrinter.cpp
    R llvm/lib/DebugInfo/DWARF/DWARFCFIProgram.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
    R llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
    A llvm/lib/DebugInfo/DWARF/DWARFExpressionPrinter.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
    A llvm/lib/DebugInfo/DWARF/LowLevel/CMakeLists.txt
    A llvm/lib/DebugInfo/DWARF/LowLevel/DWARFCFIProgram.cpp
    A llvm/lib/DebugInfo/DWARF/LowLevel/DWARFExpression.cpp
    M llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
    M llvm/lib/ProfileData/CMakeLists.txt
    M llvm/lib/ProfileData/InstrProfCorrelator.cpp
    M llvm/tools/dsymutil/CMakeLists.txt
    M llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
    M llvm/tools/llvm-dwarfdump/CMakeLists.txt
    M llvm/tools/llvm-dwarfdump/Statistics.cpp
    M llvm/tools/llvm-dwarfutil/CMakeLists.txt
    M llvm/tools/llvm-dwarfutil/DebugInfoLinker.cpp
    M llvm/tools/llvm-objdump/CMakeLists.txt
    M llvm/tools/llvm-objdump/SourcePrinter.cpp
    M llvm/unittests/DebugInfo/DWARF/CMakeLists.txt
    M llvm/unittests/DebugInfo/DWARF/DWARFExpressionCompactPrinterTest.cpp
    M llvm/unittests/DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp
    M utils/bazel/llvm-project-overlay/bolt/BUILD.bazel
    M utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

  Log Message:
  -----------
  [NFC][DebugInfo][DWARF] Create new low-level dwarf library (#145081)

This is the culmination of a series of changes described in [1].
    
Although somewhat large by line count, it is almost entirely mechanical,
creating a new library in DebugInfo/DWARF/LowLevel. This new library has
very minimal dependencies, allowing it to be used from more places than
the normal DebugInfo/DWARF library--in particular from MC.
    
I am happy to put it in another location, or to structure it differently
if that makes sense. Some have suggested in BinaryFormat, but it is not
a great fit there. But if that makes more sense to the reviewers, I can
do that.
 
Another possibility would be to use pass-through headers to allow
clients who don't care to depend only on DebugInfo/DWARF. This would be
a much less invasive change, and perhaps easier for clients. But also a
system that hides details.

Either way, I'm open.

1.
https://discourse.llvm.org/t/rfc-debuginfo-dwarf-refactor-into-to-lower-and-higher-level-libraries/86665/2



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications