[all-commits] [llvm/llvm-project] a13cf8: [ASTMatchers] Migrate away from ArrayRef(std::null...

Kazu Hirata via All-commits all-commits at lists.llvm.org
Thu Jun 26 08:41:10 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a13cf846e0c6c9f667be505eb1aae8160240cf4a
      https://github.com/llvm/llvm-project/commit/a13cf846e0c6c9f667be505eb1aae8160240cf4a
  Author: Kazu Hirata <kazu at google.com>
  Date:   2025-06-26 (Thu, 26 Jun 2025)

  Changed paths:
    M clang/lib/ASTMatchers/Dynamic/Marshallers.h

  Log Message:
  -----------
  [ASTMatchers] Migrate away from ArrayRef(std::nullopt) (NFC) (#145840)

ArrayRef has a constructor that accepts std::nullopt.  This
constructor dates back to the days when we still had llvm::Optional.

Since the use of std::nullopt outside the context of std::optional is
kind of abuse and not intuitive to new comers, I would like to move
away from the constructor and eventually remove it.

This patch migrates away from std::nullopt in favor of ArrayRef<T>().
Note that {} would be ambiguous for perfect forwarding to work here.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list