[all-commits] [llvm/llvm-project] afc6c2: [Clang] Allow the use of [[gnu::visibility]] with ...

[Nikolas Klauser via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: afc6c2bb9b43c63d5fbf2596f559917ad335ee7d
      https://github.com/llvm/llvm-project/commit/afc6c2bb9b43c63d5fbf2596f559917ad335ee7d
  Author: Nikolas Klauser <nikolasklauser at berlin.de>
  Date:   2025-06-26 (Thu, 26 Jun 2025)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/test/CodeGen/visibility.c
    M clang/test/CodeGenCXX/visibility.cpp
    M clang/test/Misc/pragma-attribute-supported-attributes-list.test
    M clang/test/Sema/attr-visibility.c

  Log Message:
  -----------
  [Clang] Allow the use of [[gnu::visibility]] with #pragma clang attribute (#145653)

I don't see any reason this shouldn't be allowed. AFAICT this is only
disabled due to the heuristics used to determine whether it makes sense
to allow the use of an attribute with `#pragma clang attribute`.

This allows libc++ to drop `_LIBCPP_HIDE_FROM_ABI` in a lot of places,
making the library significantly easier to read.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications