[all-commits] [llvm/llvm-project] d3fd79: Clarify some code based on static analysis complai...

Aaron Ballman via All-commits all-commits at lists.llvm.org
Thu Jun 26 03:56:10 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d3fd7921d4d7158a487bdc839c9fa6c3b650b997
      https://github.com/llvm/llvm-project/commit/d3fd7921d4d7158a487bdc839c9fa6c3b650b997
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2025-06-26 (Thu, 26 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/CGHLSLRuntime.cpp
    M clang/lib/Sema/SemaHLSL.cpp

  Log Message:
  -----------
  Clarify some code based on static analysis complaints; NFC (#145679)

In one case, we have a null pointer check that's unnecessary because the
only caller of the function already asserts the value is non-null.

In the other case, we've got an anti-pattern of `is` followed by `get`.
The logic was easier to repair by changing `get` to `cast`.

Neither case is a functional change.

Fixes #145525



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list