[all-commits] [llvm/llvm-project] d144eb: [Clang] Back out the source location workaround fo...

Younan Zhang via All-commits all-commits at lists.llvm.org
Thu Jun 26 02:02:35 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d144eb1d8cd3abdaec23c902aa3e5a129c9827ef
      https://github.com/llvm/llvm-project/commit/d144eb1d8cd3abdaec23c902aa3e5a129c9827ef
  Author: Younan Zhang <zyn7109 at gmail.com>
  Date:   2025-06-26 (Thu, 26 Jun 2025)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Sema/Initialization.h
    M clang/lib/Sema/SemaCast.cpp
    M clang/test/AST/ast-dump-expr.cpp

  Log Message:
  -----------
  [Clang] Back out the source location workaround for CXXConstructExpr (#145260)

This removes the workaround introduced in 3e1a9cf3b8 and 1ba7dc38d.

The workaround overwrote the right parenthesis location of the sub
expression, which could be wrong when a CXXTemporaryObjectExpr occurs
within a nested expression, e.g. `A(A(1, 2))`.

To completely take it down, we now propagate the left parenthesis source
location throughout SemaCast, such that the ParenOrBraceRange can be
properly set at the point of its creation.

Fixes https://github.com/llvm/llvm-project/issues/143711



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list