[all-commits] [llvm/llvm-project] 7aeb1a: Fix Solaris buildbot (#145737)

sivadeilra via All-commits all-commits at lists.llvm.org
Wed Jun 25 12:08:58 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7aeb1a1fd8bd8d376cd58d3341c739be8f3ac4a7
      https://github.com/llvm/llvm-project/commit/7aeb1a1fd8bd8d376cd58d3341c739be8f3ac4a7
  Author: sivadeilra <arlie.davis at microsoft.com>
  Date:   2025-06-25 (Wed, 25 Jun 2025)

  Changed paths:
    M clang/test/CodeGen/X86/ms-secure-hotpatch-bad-file.c
    M clang/test/CodeGen/X86/ms-secure-hotpatch-cpp.cpp
    M clang/test/CodeGen/X86/ms-secure-hotpatch-eh.cpp
    M clang/test/CodeGen/X86/ms-secure-hotpatch-globals.c
    M clang/test/CodeGen/X86/ms-secure-hotpatch-lto.c
    M clang/test/CodeGen/X86/ms-secure-hotpatch.c

  Log Message:
  -----------
  Fix Solaris buildbot (#145737)

#145565 broke the Solaris buildbot, due to a subtlety in how
command-lines are parsed, which is different between Windows and
non-Windows platforms. The fix is to use `--` to force passing the rest
of args without interpretation. This is similar to existing tests for
`%clang_cl`, such as
`clang/test/CodeGen/debug-info-codeview-buildinfo.c`.

Currently, CI jobs for PRs do not detect this problem. Fixing that is
tracked in issue #145713.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list