[all-commits] [llvm/llvm-project] 022e1e: [mlir][memref]: Fix Bug in GlobalOp Verifier (#144...

[Jack Frankland via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 022e1e99f3b017ac1baf8b65f5a48212c5fca2ae
      https://github.com/llvm/llvm-project/commit/022e1e99f3b017ac1baf8b65f5a48212c5fca2ae
  Author: Jack Frankland <jack.frankland at arm.com>
  Date:   2025-06-25 (Wed, 25 Jun 2025)

  Changed paths:
    M mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
    M mlir/test/Dialect/MemRef/invalid.mlir
    M mlir/test/Dialect/MemRef/ops.mlir

  Log Message:
  -----------
  [mlir][memref]: Fix Bug in GlobalOp Verifier (#144900)

When comparing the type of the initializer in a `memref::GlobalOp`
against its result only consider the element type and the shape. Other
attributes such as memory space should be ignored since comparing these
between tensors and memrefs doesn't make sense and constructing a memref
in a specific memory space with a tensor that has no such attribute
should be valid.

Signed-off-by: Jack Frankland <jack.frankland at arm.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications