[all-commits] [llvm/llvm-project] 072ce7: [MLIR][AArch64] Check indexing maps before checkin...

Momchil Velikov via All-commits all-commits at lists.llvm.org
Wed Jun 25 06:47:04 PDT 2025


  Branch: refs/heads/users/momchil-velikov/sve-i8mm-check-maps
  Home:   https://github.com/llvm/llvm-project
  Commit: 072ce70ddb305c078f02087b7b9d70335581f868
      https://github.com/llvm/llvm-project/commit/072ce70ddb305c078f02087b7b9d70335581f868
  Author: Momchil Velikov <momchil.velikov at arm.com>
  Date:   2025-06-25 (Wed, 25 Jun 2025)

  Changed paths:
    M mlir/lib/Dialect/ArmSVE/Transforms/LowerContractionToSVEI8MMPattern.cpp

  Log Message:
  -----------
  [MLIR][AArch64] Check indexing maps before checking for dimensions compatibility

In `LowerContractionToSVEI8MMPattern` check we have the expected
indexing maps before deciding which operand dimension must match
with which.

For example, with indexing map like:

    lhs: (m, n, k) -> (m, k)
    rhs: (m, n, k) -> (n, k)
    acc: (m, n, k) -> (m, n)

we would like the second `lhs` dimension (columns) to match with
the second `rhs` (rows, transposed) whereas with indexing maps like

    lhs: (m, n, k) -> (m, k)
    rhs: (m, n, k) -> (k, n)
    acc: (m, n, k) -> (m, n)

we would like the second `lhs` dimension (columns) to match with
the first `rhs` (rows, canonical matrix multiplication).

Since only the first kind of indexing maps is supported, the patch
does not change anything of significance, just the notification message
when the pattern would fail to apply anyway.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list