[all-commits] [llvm/llvm-project] 9fbc44: Triple: Add BridgeOS to isOSDarwin

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Jun 25 04:04:10 PDT 2025


  Branch: refs/heads/users/arsenm/triple/add-bridgeos-isosdarwin
  Home:   https://github.com/llvm/llvm-project
  Commit: 9fbc44ff216604f6ec588df1f8cc6fba185dff54
      https://github.com/llvm/llvm-project/commit/9fbc44ff216604f6ec588df1f8cc6fba185dff54
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-06-25 (Wed, 25 Jun 2025)

  Changed paths:
    M llvm/include/llvm/TargetParser/Triple.h
    M llvm/lib/IR/RuntimeLibcalls.cpp
    M llvm/lib/MC/MCStreamer.cpp
    M llvm/test/CodeGen/AArch64/exp10-libcall-names.ll
    M llvm/unittests/TargetParser/TripleTest.cpp

  Log Message:
  -----------
  Triple: Add BridgeOS to isOSDarwin

This fixes a TODO and avoids a special case. Also required
hacking up a few cases to avoid asserting in codegen; it's not
confidence inspiring that there is only one codegen test using
a bridgeos triple and its specifically for the exp10 libcall
names.

This also changes the behavior, losing an extra leading _ in the
emitted name matching the other apple outputs. I have no idea if
this is right or not. IMO it's someone from apple's problem to fix
it and add appropriate test coverage, or we can rip all references
to BridgeOS out from upstream.


  Commit: 0c07d89ca9d8b3c5b72bc919c1f8b1f2a1783c26
      https://github.com/llvm/llvm-project/commit/0c07d89ca9d8b3c5b72bc919c1f8b1f2a1783c26
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-06-25 (Wed, 25 Jun 2025)

  Changed paths:
    M llvm/include/llvm/TargetParser/Triple.h
    M llvm/lib/MC/MCStreamer.cpp

  Log Message:
  -----------
  Address comments


Compare: https://github.com/llvm/llvm-project/compare/804c74f114d1...0c07d89ca9d8

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list