[all-commits] [llvm/llvm-project] 0c5097: [mlir] Walk nested non-symbol table ops in symbol ...

[Jacques Pienaar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c50971460cb4ff808990ade61e2d5688b9b9d73
      https://github.com/llvm/llvm-project/commit/0c50971460cb4ff808990ade61e2d5688b9b9d73
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2025-06-24 (Tue, 24 Jun 2025)

  Changed paths:
    M mlir/lib/Transforms/SymbolDCE.cpp
    M mlir/test/Transforms/test-symbol-dce.mlir

  Log Message:
  -----------
  [mlir] Walk nested non-symbol table ops in symbol dce (#143353)

The previous code was effectively that a symbol is dead if was not
nested in sequence of SymbolTables. But one can have operations that one
cannot delete/DCE that refers to symbols which one could delete which
resulted in symbol-dce deleting symbols that are still referenced and
the resulting IR being invalid. This changes it so that all operations
inside non SymbolTable op are considered to find nested SymbolTable ops.

---------

Co-authored-by: Mehdi Amini <joker.eph at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications