[all-commits] [llvm/llvm-project] 1128a4: [HLSL] Don't use CreateRuntimeFunction for intrins...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1128a4fd2c3a70ba61eead2ce093a9c31aa2970e
      https://github.com/llvm/llvm-project/commit/1128a4fd2c3a70ba61eead2ce093a9c31aa2970e
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2025-06-23 (Mon, 23 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/CGHLSLBuiltins.cpp
    M clang/test/CodeGenHLSL/builtins/WaveActiveMax.hlsl
    M clang/test/CodeGenHLSL/builtins/WaveActiveSum.hlsl
    M clang/test/CodeGenHLSL/builtins/WaveReadLaneAt.hlsl

  Log Message:
  -----------
  [HLSL] Don't use CreateRuntimeFunction for intrinsics (#145334)

HLSL uses CreateRuntimeFunction for three intrinsics. This is pretty
unusual thing to do, and doesn't match what the rest of the file does.

I suspect this might be because these are convergent calls, but the
intrinsics themselves are already marked convergent, so it's not
necessary for clang to manually add the attribute.

This does lose the spir_func CC on the intrinsic declaration, but again,
CC should not be relevant to intrinsics at all.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications