[all-commits] [llvm/llvm-project] 26f3f2: [MLIR][NFC] Declare RuntimeVerifiableOpInterface f...

[Artemiy Bulavin via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26f3f24a4f0a67eb23d255aba7a73a12bee1db11
      https://github.com/llvm/llvm-project/commit/26f3f24a4f0a67eb23d255aba7a73a12bee1db11
  Author: Artemiy Bulavin <artemiyb at graphcore.ai>
  Date:   2025-06-23 (Mon, 23 Jun 2025)

  Changed paths:
    M mlir/lib/Dialect/MemRef/IR/MemRefDialect.cpp

  Log Message:
  -----------
  [MLIR][NFC] Declare RuntimeVerifiableOpInterface for memref ops that have an implementation  (#145230)

Previously running `-generate-runtime-verification` on an IR containing
`memref.reinterpret_cast` would crash because its implementation of the
`RuntimeVerifiableOpInterface` was removed in
https://github.com/llvm/llvm-project/pull/132547 but its associated
entry in `declarePromisedInterface` was never removed.

This causes an error when you try and run
`-generate-runtime-verification` on an IR containing
`memref.reinterpret_cast` that looks like

```
LLVM ERROR: checking for an interface (`mlir::RuntimeVerifiableOpInterface`) that was promised by dialect 'memref' but never implemented. This is generally an indication that the dialect extension implementing the interface was never registered.
```
as reported in https://github.com/llvm/llvm-project/issues/144028.

In this PR I also added all the ops that do have implementations of this
interface in
`mlir/lib/Dialect/MemRef/Transforms/RuntimeOpVerification.cpp` to the
`declarePromisedInterface` for consistency.

Fixes https://github.com/llvm/llvm-project/issues/144028



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications