[all-commits] [llvm/llvm-project] f9fce4: [ORC] Fix potential stack corruption in Platform::...

Lang Hames via All-commits all-commits at lists.llvm.org
Sun Jun 22 16:52:14 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f9fce4975bbad835deba6e639c21a62154dd8c14
      https://github.com/llvm/llvm-project/commit/f9fce4975bbad835deba6e639c21a62154dd8c14
  Author: Lang Hames <lhames at gmail.com>
  Date:   2025-06-23 (Mon, 23 Jun 2025)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/Core.cpp

  Log Message:
  -----------
  [ORC] Fix potential stack corruption in Platform::lookupInitSymbols.

We can't exit early when on error here as some threads may still be holding
references to LookupMutex.

Since we don't need high performance in the error case the easy solution is to
drop the early-exit in the error case and wait for all tasks to complete before
returning the error.

Thanks to Jameson Nash for spotting this bug!



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list