[all-commits] [llvm/llvm-project] 0921bf: [mlir][Transforms] Dialect conversion: Add missing...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0921bfd81d57eb652e1cb1e12ea4dd3df037d222
      https://github.com/llvm/llvm-project/commit/0921bfd81d57eb652e1cb1e12ea4dd3df037d222
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-06-21 (Sat, 21 Jun 2025)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    M mlir/test/Transforms/test-legalizer.mlir

  Log Message:
  -----------
  [mlir][Transforms] Dialect conversion: Add missing erasure notifications (#145030)

Add missing listener notifications when erasing nested
blocks/operations.

This commit also moves some of the functionality from
`ConversionPatternRewriter` to `ConversionPatternRewriterImpl`. This is
in preparation of the One-Shot Dialect Conversion refactoring: The
implementations in `ConversionPatternRewriter` should be as simple as
possible, so that a switch between "rollback allowed" and "rollback not
allowed" can be inserted at that level. (In the latter case,
`ConversionPatternRewriterImpl` can be bypassed to some degree, and
`PatternRewriter::eraseBlock` etc. can be used.)

Depends on #145018.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications