[all-commits] [llvm/llvm-project] 887222: [mlir] Migrate away from ArrayRef(std::nullopt) (N...

[Kazu Hirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 887222e3526fbe08e748a33f740296ac22bf1ab1
      https://github.com/llvm/llvm-project/commit/887222e3526fbe08e748a33f740296ac22bf1ab1
  Author: Kazu Hirata <kazu at google.com>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M mlir/include/mlir/AsmParser/AsmParserState.h
    M mlir/include/mlir/Dialect/Linalg/Utils/Utils.h
    M mlir/include/mlir/Dialect/Tensor/Utils/Utils.h
    M mlir/include/mlir/ExecutionEngine/ExecutionEngine.h
    M mlir/include/mlir/IR/BlockSupport.h
    M mlir/include/mlir/IR/Builders.h
    M mlir/include/mlir/IR/BuiltinTypes.td
    M mlir/include/mlir/IR/PatternMatch.h
    M mlir/include/mlir/IR/Region.h
    M mlir/include/mlir/IR/SymbolTable.h
    M mlir/include/mlir/IR/TypeRange.h
    M mlir/include/mlir/IR/ValueRange.h
    M mlir/include/mlir/Rewrite/FrozenRewritePatternSet.h
    M mlir/include/mlir/Tools/PDLL/AST/Types.h
    M mlir/include/mlir/Transforms/DialectConversion.h
    M mlir/include/mlir/Transforms/Passes.h
    M mlir/lib/Dialect/GPU/Transforms/DecomposeMemRefs.cpp
    M mlir/lib/Dialect/LLVMIR/IR/TypeDetail.h
    M mlir/lib/Pass/PassStatistics.cpp
    M mlir/unittests/IR/OperationSupportTest.cpp
    M mlir/unittests/IR/ValueTest.cpp

  Log Message:
  -----------
  [mlir] Migrate away from ArrayRef(std::nullopt) (NFC) (#144989)

ArrayRef has a constructor that accepts std::nullopt.  This
constructor dates back to the days when we still had llvm::Optional.

Since the use of std::nullopt outside the context of std::optional is
kind of abuse and not intuitive to new comers, I would like to move
away from the constructor and eventually remove it.

This patch takes care of the mlir side of the migration, starting with
straightforward places where I see ArrayRef or ValueRange nearby.
Note that ValueRange has a constructor that forwards arguments to an
ArrayRef constructor.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications